Skip to content

K8SPS-430: support updating DNS names #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

K8SPS-430: support updating DNS names #993

wants to merge 3 commits into from

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Aug 11, 2025

K8SPS-430 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPS-430

CHANGE DESCRIPTION

Problem:
cert-manager certificates are not refreshed when .spec.tls.SANs is updated.

Cause:
The operator currently verifies whether the TLS secret's ownerReferences points to the PerconaServerMySQL. If it does not, the operator skips updating the certificate. This logic is intended to prevent updating TLS secrets created by the user.

Solution:
Improve the logic for detecting user certificates. First, operator should check if the TLS secret was created by cert-manager. If so, verify that the ownerReferences of the issuer point to the PerconaServerMySQL. If both conditions are met, proceed with updating the certificates.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Aug 11, 2025
@pooknull pooknull added this to the v0.12.0 milestone Aug 11, 2025
@pooknull pooknull marked this pull request as ready for review August 11, 2025 12:47
@JNKPercona
Copy link
Collaborator

Test name Status
version-service passed
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-scheduled-backup passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
scheduled-backup failure
service-per-pod passed
sidecars passed
smart-update passed
storage passed
tls-cert-manager passed
users passed
pvc-resize failure
We run 36 out of 36

commit: 69fc1ae
image: perconalab/percona-server-mysql-operator:PR-993-69fc1ae0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants