-
Notifications
You must be signed in to change notification settings - Fork 31
K8SPS-430: support updating DNS names #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
reviewed
Aug 20, 2025
Co-authored-by: Ege Güneş <[email protected]>
egegunes
approved these changes
Aug 27, 2025
gkech
approved these changes
Aug 27, 2025
hors
approved these changes
Aug 27, 2025
commit: bd4cc52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPS-430
CHANGE DESCRIPTION
Problem:
cert-manager certificates are not refreshed when
.spec.tls.SANs
is updated.Cause:
The operator currently verifies whether the TLS secret's
ownerReferences
points to thePerconaServerMySQL
. If it does not, the operator skips updating the certificate. This logic is intended to prevent updating TLS secrets created by the user.Solution:
Improve the logic for detecting user certificates. First, operator should check if the TLS secret was created by cert-manager. If so, verify that the
ownerReferences
of the issuer point to thePerconaServerMySQL
. If both conditions are met, proceed with updating the certificates.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability