Skip to content

K8SPS-339: add dataSource and dataSourceRef fields #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 26, 2025
Merged

K8SPS-339: add dataSource and dataSourceRef fields #998

merged 6 commits into from
Aug 26, 2025

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Aug 15, 2025 •
edited
Loading

K8SPS-339 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPS-339

DESCRIPTION

This PR adds 2 fields:

  • .spec.mysql.volumeSpec.persistentVolumeClaim.dataSource
  • .spec.mysql.volumeSpec.persistentVolumeClaim.dataSourceRef

Helm chart PR: percona/percona-helm-charts#616

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label Aug 15, 2025
@hors hors added this to the v0.12.0 milestone Aug 15, 2025
@pooknull pooknull marked this pull request as ready for review August 20, 2025 20:29
gkech
gkech reviewed Aug 21, 2025
View reviewed changes
pkg/k8s/pvc.go
Comment on lines +19 to +20
DataSource: spec.PersistentVolumeClaim.DataSource,
DataSourceRef: spec.PersistentVolumeClaim.DataSourceRef,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the existing unit test in pkg/k8s/pvc_test.go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a7eaecd

@pull-request-size pull-request-size bot added size/M 30-99 lines and removed size/S 10-29 lines labels Aug 21, 2025
@pooknull pooknull requested a review from gkech August 21, 2025 12:23
@JNKPercona
Copy link
Collaborator

Test name Status
version-service passed
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
async-data-at-rest-encryption passed
gr-data-at-rest-encryption passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-scheduled-backup passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
scheduled-backup passed
service-per-pod passed
sidecars passed
smart-update passed
storage passed
tls-cert-manager passed
users passed
pvc-resize passed
We run 38 out of 38

commit: 648bf0e
image: perconalab/percona-server-mysql-operator:PR-998-648bf0e5

@hors hors merged commit 550a4bd into main Aug 26, 2025
10 of 12 checks passed
@hors hors deleted the K8SPS-339 branch August 26, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkech gkech gkech approved these changes

@nmarukovich nmarukovich nmarukovich approved these changes

@hors hors Awaiting requested review from hors hors is a code owner

@egegunes egegunes Awaiting requested review from egegunes egegunes is a code owner

Assignees
No one assigned
Labels
size/M 30-99 lines
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pooknull @JNKPercona @gkech @nmarukovich @hors