Skip to content

K8SPS-339: add dataSource and dataSourceRef fields #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2025
Merged

K8SPS-339: add dataSource and dataSourceRef fields #998

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
19ba1be
K8SPS-339: add dataSource and dataSourceRef fields
pooknull Aug 15, 2025
6306b11
Merge branch 'main' into K8SPS-339
pooknull Aug 20, 2025
a7eaecd
update unit-test
pooknull Aug 21, 2025
d484f0a
Merge branch 'main' into K8SPS-339
gkech Aug 22, 2025
648bf0e
Merge branch 'main' into K8SPS-339
pooknull Aug 25, 2025
d756337
Merge branch 'main' into K8SPS-339
hors Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions deploy/cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,15 @@ spec:
# path: /data
# type: Directory
persistentVolumeClaim:
# dataSource:
# apiGroup: ""
# kind: PersistentVolumeClaim
# name: source-pvc
# dataSourceRef:
# apiGroup: ""
# kind: PersistentVolumeClaim
# name: source-pvc
# namespace: default
# storageClassName: standard
# accessModes: [ "ReadWriteOnce" ]
resources:
Expand Down
2 changes: 2 additions & 0 deletions pkg/k8s/pvc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ func PVC(name string, spec *apiv1alpha1.VolumeSpec) corev1.PersistentVolumeClaim
StorageClassName: spec.PersistentVolumeClaim.StorageClassName,
AccessModes: spec.PersistentVolumeClaim.AccessModes,
Resources: spec.PersistentVolumeClaim.Resources,
DataSource: spec.PersistentVolumeClaim.DataSource,
DataSourceRef: spec.PersistentVolumeClaim.DataSourceRef,
Comment on lines +19 to +20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the existing unit test in pkg/k8s/pvc_test.go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a7eaecd

},
}
}
Loading