PS-9734 merge: Code refresh for 8.0.42-33 (os_file_set_nocache() fix)

https://perconadev.atlassian.net/browse/PS-9734

Removed unused overload of 'os_file_set_nocache()' function. The return value
type of the original function changed back to 'void' as in upstream.

Author: percona-ysorokin

storage/innobase/include/os0file.h

@@ -816,22 +816,10 @@ null-terminated string
 @param[in]      operation_name  "open" or "create"; used in the diagnostic
                                 message
 @param[in]      on_error_silent if true then don't print any message to the log
-@return true if operation is success and false */
-bool os_file_set_nocache(int fd, const char *file_name,
+*/
+void os_file_set_nocache(int fd, const char *file_name,
                          const char *operation_name,
                          bool on_error_silent = false);
-
-/** Tries to disable OS caching on an opened file file.
-@param[in]	    file		        file to alter
-@param[in]	    file_name	      file name, used in the diagnostic message
-@param[in]	    name		        "open" or "create"; used in the diagnostic
-                                message
-@param[in]      on_error_silent if true then don't print any message to the log
-@return true if operation is success and false */
-static inline bool os_file_set_nocache(pfs_os_file_t file,
-                                       const char *file_name,
-                                       const char *operation_name,
-                                       bool on_error_silent = false);
 /** NOTE! Use the corresponding macro os_file_create(), not directly
 this function!
 Opens an existing file or creates a new.

storage/innobase/include/os0file.ic

@@ -524,17 +524,3 @@ static inline bool pfs_os_file_set_eof_at_func(pfs_os_file_t file, uint64_t new_
 }
 
 #endif /* UNIV_PFS_IO */
-
-/** Tries to disable OS caching on an opened file file.
-@param[in]	file		        file to alter
-@param[in]	file_name	      file name, used in the diagnostic message
-@param[in]	name		        "open" or "create"; used in the diagnostic
-                            message
-@param[in]  on_error_silent if true then don't print any message to the log
-@return true if operation is success and false */
-static inline bool os_file_set_nocache(pfs_os_file_t file, const char *file_name,
-                                       const char *operation_name,
-                                       bool on_error_silent) {
-  return os_file_set_nocache(file.m_file, file_name, operation_name,
-                             on_error_silent);
-}

storage/innobase/os/os0file.cc

@@ -5513,7 +5513,7 @@ static bool os_file_handle_error_no_exit(const char *name,
       os_file_handle_error_cond_exit(name, operation, false, on_error_silent));
 }
 
-bool os_file_set_nocache(int fd [[maybe_unused]],
+void os_file_set_nocache(int fd [[maybe_unused]],
                          const char *file_name [[maybe_unused]],
                          const char *operation_name [[maybe_unused]],
                          bool on_error_silent [[maybe_unused]]) {
@@ -5527,7 +5527,6 @@ bool os_file_set_nocache(int fd [[maybe_unused]],
         << operation_name << ": " << strerror(errno_save)
         << ","
            " continuing anyway.";
-    return false;
   }
 #elif defined(O_DIRECT)
   if (fcntl(fd, F_SETFL, O_DIRECT) == -1 && !on_error_silent) {
@@ -5557,10 +5556,8 @@ bool os_file_set_nocache(int fd [[maybe_unused]],
                               << "; " << operation_name << " : "
                               << strerror(errno_save) << ", continuing anyway.";
     }
-    return false;
   }
 #endif /* !(UNIV_SOLARIS && DIRECTIO_ON) && O_DIRECT */
-  return true;
 }
 
 bool os_file_set_size_fast(const char *name, pfs_os_file_t pfs_file,