K8SPXC-1781: [bugfix] cannot use custom proxysql config

[mayankshah1607]

CHANGE DESCRIPTION

Problem:
Specifying custom proxysql config leads to crashing proxysql pods

Cause:

• Custom config is mounted as a ConfigMap in /etc/proxysql/proxysql.conf
• proxysql-entrypoint script tries to modify this /etc/proxysql/proxysql.conf, but when it is mounted from the ConfigMap, it fails as the volume is read-only
• This was an issue earlier as well, but a recent change in the script added errexit to the script which now causes the pods to fail

Solution:

• Mount the ConfigMap at /etc/proxysql/custom/
• The default proxysql.conf is always copied to /etc/proxysql/proxysql.conf as the first step
• But if the custom config is present at /etc/proxysql/custom/ , we will copy it to /etc/proxysql/proxysql.conf replacing it from previous step
• This way we ensure that the script never tries to modify the ConfigMap volume filesystem

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?
• Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are all needed new/changed options added to the Helm Chart?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported PXC version?
• Does the change support oldest and newest supported Kubernetes version?

[egegunes]

changing this without version check will cause a restart, no?

[mayankshah1607]

Right, yeah.. Updated

[JNKPercona]

Test Name	Result	Time
auto-tuning-8-0	passed	00:00:00
allocator-8-0	passed	00:00:00
backup-storage-tls-8-0	passed	00:00:00
cross-site-8-0	passed	00:00:00
custom-users-8-0	passed	00:00:00
demand-backup-cloud-8-0	passed	00:00:00
demand-backup-cloud-pxb-8-0	passed	00:00:00
demand-backup-encrypted-with-tls-8-0	passed	00:00:00
demand-backup-encrypted-with-tls-8-4	passed	00:00:00
demand-backup-encrypted-with-tls-pxb-8-0	passed	00:00:00
demand-backup-encrypted-with-tls-pxb-8-4	passed	00:00:00
demand-backup-8-0	passed	00:00:00
demand-backup-flow-control-8-0	passed	00:00:00
demand-backup-parallel-8-0	passed	00:00:00
demand-backup-without-passwords-8-0	passed	00:00:00
extra-pvc-8-0	passed	00:00:00
haproxy-5-7	passed	00:00:00
haproxy-8-0	passed	00:00:00
init-deploy-5-7	passed	00:00:00
init-deploy-8-0	passed	00:00:00
limits-8-0	passed	00:00:00
monitoring-2-0-8-0	passed	00:00:00
monitoring-pmm3-8-0	passed	00:00:00
one-pod-5-7	passed	00:00:00
one-pod-8-0	passed	00:00:00
pitr-8-0	passed	00:00:00
pitr-8-4	passed	00:41:21
pitr-pxb-8-0	passed	00:00:00
pitr-pxb-8-4	passed	00:00:00
pitr-gap-errors-8-0	passed	00:00:00
pitr-gap-errors-8-4	passed	00:00:00
proxy-protocol-8-0	passed	00:00:00
proxy-switch-8-0	passed	00:00:00
proxysql-sidecar-res-limits-8-0	passed	00:00:00
proxysql-scheduler-8-0	passed	00:00:00
pvc-resize-5-7	passed	00:00:00
pvc-resize-8-0	passed	00:00:00
recreate-8-0	passed	00:00:00
restore-to-encrypted-cluster-8-0	passed	00:00:00
restore-to-encrypted-cluster-8-4	passed	00:00:00
restore-to-encrypted-cluster-pxb-8-0	passed	00:00:00
scaling-proxysql-8-0	passed	00:00:00
scaling-8-0	passed	00:00:00
scheduled-backup-5-7	passed	00:00:00
scheduled-backup-8-0	passed	00:00:00
security-context-8-0	passed	00:00:00
smart-update1-8-0	passed	00:00:00
smart-update2-8-0	passed	00:00:00
storage-8-0	passed	00:00:00
tls-issue-cert-manager-ref-8-0	passed	00:00:00
tls-issue-cert-manager-8-0	passed	00:00:00
tls-issue-self-8-0	passed	00:00:00
upgrade-consistency-8-0	passed	00:00:00
upgrade-haproxy-5-7	passed	00:00:00
upgrade-haproxy-8-0	passed	00:00:00
upgrade-proxysql-5-7	passed	00:00:00
upgrade-proxysql-8-0	passed	00:00:00
users-5-7	passed	00:00:00
users-8-0	passed	00:00:00
users-scheduler-8-4	passed	00:00:00
validation-hook-8-0	passed	00:00:00

Summary	Value
Tests Run	61/61
Job Duration	01:04:58
Total Test Time	00:41:21

commit: d401e0a
image: perconalab/percona-xtradb-cluster-operator:PR-2325-d401e0a9