Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/prepare_restored_cluster.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
function get_password() {
local user=$1

escape_special $(</etc/mysql/mysql-users-secret/${user})

Check warning on line 16 in build/prepare_restored_cluster.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] build/prepare_restored_cluster.sh#L16 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./build/prepare_restored_cluster.sh:16:17: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 16 in build/prepare_restored_cluster.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] build/prepare_restored_cluster.sh#L16 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./build/prepare_restored_cluster.sh:16:50: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
}

MYSQL_VERSION=$(mysqld -V | awk '{print $3}' | awk -F'.' '{print $1"."$2}')
Expand All @@ -21,7 +21,7 @@

vault_secret="/etc/mysql/vault-keyring-secret/keyring_vault.conf"
if [ -f "${vault_secret}" ]; then
if [[ $MYSQL_VERSION == '8.0' ]]; then
if [[ $MYSQL_VERSION =~ ^(5\.7|8\.0)$ ]]; then
sed -i "/\[mysqld\]/a early-plugin-load=keyring_vault.so" $CFG
sed -i "/\[mysqld\]/a keyring_vault_config=${vault_secret}" $CFG
fi
Expand Down
2 changes: 1 addition & 1 deletion build/pxc-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ fi
# if vault secret file exists we assume we need to turn on encryption
vault_secret="/etc/mysql/vault-keyring-secret/keyring_vault.conf"
if [ -f "$vault_secret" ]; then
if [[ $MYSQL_VERSION == '8.0' ]]; then
if [[ $MYSQL_VERSION =~ ^(5\.7|8\.0)$ ]]; then
sed -i "/\[mysqld\]/a early-plugin-load=keyring_vault.so" $CFG
sed -i "/\[mysqld\]/a keyring_vault_config=$vault_secret" $CFG
fi
Expand Down
2 changes: 2 additions & 0 deletions e2e-tests/run-pr.csv
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ cross-site,8.0
custom-users,8.0
demand-backup-cloud,8.0
demand-backup-cloud-pxb,8.0
demand-backup-encrypted-with-tls,5.7
demand-backup-encrypted-with-tls,8.0
demand-backup-encrypted-with-tls,8.4
demand-backup-encrypted-with-tls-pxb,5.7
demand-backup-encrypted-with-tls-pxb,8.0
demand-backup-encrypted-with-tls-pxb,8.4
demand-backup,8.0
Expand Down
Loading