PMM-14694: reduce saas package dependency #4900
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v3 #4900 +/- ##
==========================================
+ Coverage 45.93% 46.01% +0.08%
==========================================
Files 366 377 +11
Lines 38427 39228 +801
==========================================
+ Hits 17651 18052 +401
- Misses 19078 19378 +300
- Partials 1698 1798 +100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
idoqo
requested review from
JiriCtvrtka,
ademidoff and
maxkondr
and removed request for
a team
There was a problem hiding this comment.
as I remember signatures were used in order to make sure that received data (advisor, alert template, etc) are really originated by Percona (signed by Percona's private key). in case the templates are moved to pmm repo itself - is it still required to check the signature?
There was a problem hiding this comment.
You are raising a good question! Let's prepare for a discussion on the next BE call.
There was a problem hiding this comment.
FYI: we will be asked to source the advisors and alert templates from a GitHub repo. This is why I'm a bit reluctant to drop them now. It's never late to do that.
managed/pi/check/check.go
Outdated
| case MySQL: | ||
| fallthrough | ||
| case PostgreSQL: | ||
| fallthrough | ||
| case MongoDB: | ||
| return nil |
There was a problem hiding this comment.
| case MySQL: | |
| fallthrough | |
| case PostgreSQL: | |
| fallthrough | |
| case MongoDB: | |
| return nil | |
| case MySQL, PostgreSQL, MongoDB: | |
| return nil |
managed/pi/check/check.go
Outdated
| case Standard: | ||
| fallthrough | ||
| case Frequent: | ||
| fallthrough | ||
| case Rare: | ||
| fallthrough |
There was a problem hiding this comment.
Let's get rid of fallthrough in favor of comma-separated cases.
PMM-14694
Percona-Lab/pmm-submodules#4182