PoC: Use system() instead of exec*() for our archive and restore commands
#522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltz
force-pushed
the
tde/archive-restore-system
branch
from
2224094 to
0a9344d
Compare
jeltz
changed the title
system() instead of exec*() for our archive and restore commands
jeltz
force-pushed
the
tde/archive-restore-system
branch
from
0a9344d to
b4543f8
Compare
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (82.41%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #522 +/- ##
=====================================================
+ Coverage 82.23% 82.41% +0.18%
=====================================================
Files 25 25
Lines 3180 3151 -29
Branches 516 503 -13
=====================================================
- Hits 2615 2597 -18
+ Misses 456 447 -9
+ Partials 109 107 -2
🚀 New features to boost your workflow:
|
jeltz
force-pushed
the
tde/archive-restore-system
branch
from
b4543f8 to
c6abbd2
Compare
…ands Instead of using exec() and replacing the path where we find a while argument match the path we use system() with another layer of placeholders.
jeltz
force-pushed
the
tde/archive-restore-system
branch
from
c6abbd2 to
412ac73
Compare
Collaborator
|
I am leaning towards this solution being better. I think it's a bit of a hack to replace the paths as the previous one does. |
Collaborator
Author
|
Superseeded by #526. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
exec()and replacing the path where we find a while argument match the path we usesystem()with another layer of placeholders.