Skip to content

Fix checkpointer shared memory allocation #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anonymou0719 wants to merge 1 commit into from
Closed

Fix checkpointer shared memory allocation #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/backend/postmaster/checkpointer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,11 +894,14 @@ CheckpointerShmemSize(void)
Size size;

/*
* Currently, the size of the requests[] array is arbitrarily set equal to
* NBuffers. This may prove too large or small ...
* The size of the requests[] array is arbitrarily set equal to NBuffers.
* But there is a cap of MAX_CHECKPOINT_REQUESTS to prevent accumulating
* too many checkpoint requests in the ring buffer.
*/
size = offsetof(CheckpointerShmemStruct, requests);
size = add_size(size, mul_size(NBuffers, sizeof(CheckpointerRequest)));
size = add_size(size, mul_size(Min(NBuffers,
MAX_CHECKPOINT_REQUESTS),
sizeof(CheckpointerRequest)));

return size;
}
Expand Down