Skip to content

improve oauth dev flow and publish frontend ghcr images#38

Open
phenix3443 wants to merge 28 commits intoperfect-panel:mainfrom
phenix3443:main
Open

improve oauth dev flow and publish frontend ghcr images#38
phenix3443 wants to merge 28 commits intoperfect-panel:mainfrom
phenix3443:main

Conversation

@phenix3443
Copy link
Copy Markdown
Contributor

@phenix3443 phenix3443 commented Apr 15, 2026

Summary

  • improve the user OAuth local development flow with configurable dev hosts, provider metadata, redirect bridge pages, and clearer loading or empty auth states
  • fix the admin login page so the animation layer no longer blocks clicks on the auth form
  • add a GitHub Actions workflow and Dockerfiles to publish ppanel-admin-web and ppanel-user-web images to GHCR

Validation

  • no additional local validation was run for this metadata update

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for ppane-docs ready!

Name Link
🔨 Latest commit 7ac4595
🔍 Latest deploy log https://app.netlify.com/projects/ppane-docs/deploys/69e275c4644be30008fc5570
😎 Deploy Preview https://deploy-preview-38--ppane-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@phenix3443 phenix3443 changed the title [codex] sync fork main with merged development branches improve oauth dev flow and publish frontend ghcr images Apr 15, 2026
@phenix3443 phenix3443 marked this pull request as ready for review April 15, 2026 07:48
@web-ppanel
Copy link
Copy Markdown
Contributor

👋 Triage check (2026-04-16): This PR covers multiple improvements (OAuth dev flow, login page fix, GHCR publishing). Looks ready for maintainer review.

Copy link
Copy Markdown
Contributor

@web-ppanel web-ppanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! The PR is well-structured and covers several meaningful improvements.

Overall assessment: Looks good. A few minor observations:

  1. resolve-web-version.ts shell hardcoded to /bin/zsh — the shell: "/bin/zsh" in execSync may fail in CI environments (Ubuntu runners typically don't have zsh). Consider removing the shell option to use the default /bin/sh, or use bash.

  2. actions/checkout@v5 in promote-release-branch.yml — v5 doesn't exist yet; the latest stable is v4. This will cause the workflow to fail.

  3. resolveBaseURL() throws at module init — if neither VITE_API_BASE_URL nor VITE_API_PREFIX is set, the error is thrown at import time before React mounts, so the toast.error call will never be reached. The error path is correct but the toast is dead code in that scenario.

  4. Dockerfiles are minimal and functional — the two-line nginx images work fine for static assets.

  5. commonReady flag and skipErrorHandler for getUserInfo are good improvements that prevent false error toasts on unauthenticated page loads.

Please address items 1 and 2 before merge, as they will cause CI failures. Item 3 is a minor code quality note.

* fix(ci): address PR 38 review feedback

* chore(ci): use actions checkout v6
@phenix3443
Copy link
Copy Markdown
Contributor Author

Addressed via phenix3443/ppanel-frontend#8, which has now been merged into the head branch of this PR (phenix3443:main), so the updated commit is already reflected here.

Two follow-ups from the earlier review were addressed:

  • tools/resolve-web-version.ts: removed the /bin/zsh dependency by replacing the shell pipeline with a shell-independent implementation.
  • actions/checkout in the touched release workflows: updated to actions/checkout@v6.

One clarification on the earlier note about actions/checkout@v5:
v5 does exist now, so the specific concern that "v5 doesn't exist yet and would fail for that reason" is no longer accurate. I updated the workflows to v6, which is the current upstream version.

Validation:

  • confirmed the original /bin/zsh dependency was present in the earlier PR 38 head snapshot
  • verified resolveWebVersion() still falls back to sha-* when no tag is present
  • verified that when multiple version tags point at HEAD, it selects the highest version tag correctly
  • confirmed this PR now includes merge commit 8f786d7 from phenix3443/ppanel-frontend#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants