Skip to content

Conversation

@ajolipa
Copy link
Contributor

@ajolipa ajolipa commented Jan 2, 2026

In this PR

Adds a LinksBanner section to the page builder, for adding navigation-bar-esque rows of links to other pages, as in the design of some of the page heroes.

Notes

Initially I tried something more complicated where the links were optionally incorporated into the Banner section component, but I think that introduces both unnecessary complexity and unnecessary design constraints; instead I've opted here to have the link banner as its own section, but give the option of adding a negative margin to place it along the bottom of the previous section, which covers the existing use cases and seems simplest to me.

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for gbof-c19nyc-staging ready!

Name Link
🔨 Latest commit 0d1eff6
🔍 Latest deploy log https://app.netlify.com/projects/gbof-c19nyc-staging/deploys/6965162aa04a7f0008a21ba5
😎 Deploy Preview https://deploy-preview-359--gbof-c19nyc-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for pss-scavenger-hunt ready!

Name Link
🔨 Latest commit 0d1eff6
🔍 Latest deploy log https://app.netlify.com/projects/pss-scavenger-hunt/deploys/6965162af47ddc0008e3fc34
😎 Deploy Preview https://deploy-preview-359--pss-scavenger-hunt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for padp-staging ready!

Name Link
🔨 Latest commit 0d1eff6
🔍 Latest deploy log https://app.netlify.com/projects/padp-staging/deploys/6965162aa259250008f49cb2
😎 Deploy Preview https://deploy-preview-359--padp-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ajolipa ajolipa requested a review from dleadbetter January 2, 2026 07:08
@ajolipa ajolipa linked an issue Jan 2, 2026 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for juel-staging ready!

Name Link
🔨 Latest commit 0d1eff6
🔍 Latest deploy log https://app.netlify.com/projects/juel-staging/deploys/6965162a2ac4e50008cbb00a
😎 Deploy Preview https://deploy-preview-359--juel-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for universities-studying-slavery-staging ready!

Name Link
🔨 Latest commit 0d1eff6
🔍 Latest deploy log https://app.netlify.com/projects/universities-studying-slavery-staging/deploys/6965162a29d0190008ec1c50
😎 Deploy Preview https://deploy-preview-359--universities-studying-slavery-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dleadbetter dleadbetter added the next release Issues in the next release label Jan 6, 2026
Copy link
Contributor

@dleadbetter dleadbetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I really like the simplicity of the overlap field, rather than allowing a numeric value.

@ajolipa
Copy link
Contributor Author

ajolipa commented Jan 6, 2026

Nice! I really like the simplicity of the overlap field, rather than allowing a numeric value.

I'm sorry to hear that 😅 I did too, but considering there are places where sections overlap the previous section by a value other than their own height (see below e.g.), I ended up modifying this to allow a dropdown list of different values. The plus side of that is that just letting each section define a top and bottom margin makes for a 1000% UX improvement over having to add spacer sections between every other section, at least in my experience. Open to other approaches though if you have thoughts.

image

@ajolipa ajolipa merged commit ed12266 into develop Jan 12, 2026
20 checks passed
@ajolipa ajolipa deleted the RB-links-banner-section branch January 12, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next release Issues in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page Builder: Link Banner

3 participants