-
Notifications
You must be signed in to change notification settings - Fork 1
Adding links banner section to page builder #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gbof-c19nyc-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pss-scavenger-hunt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for padp-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for universities-studying-slavery-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dleadbetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I really like the simplicity of the overlap field, rather than allowing a numeric value.

In this PR
Adds a
LinksBannersection to the page builder, for adding navigation-bar-esque rows of links to other pages, as in the design of some of the page heroes.Notes
Initially I tried something more complicated where the links were optionally incorporated into the
Bannersection component, but I think that introduces both unnecessary complexity and unnecessary design constraints; instead I've opted here to have the link banner as its own section, but give the option of adding a negative margin to place it along the bottom of the previous section, which covers the existing use cases and seems simplest to me.