Skip to content

Add Support for SparkFun SerLCD Display#88

Merged
gsexton merged 6 commits intoperiph:mainfrom
gsexton:SerLCD
Feb 9, 2025
Merged

Add Support for SparkFun SerLCD Display#88
gsexton merged 6 commits intoperiph:mainfrom
gsexton:SerLCD

Conversation

@gsexton
Copy link
Contributor

@gsexton gsexton commented Jan 13, 2025

Bumps conn to 3.7.2 to get the new text interface, and the GPIO group interface.

@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 75.59055% with 31 lines in your changes missing coverage. Please review.

Project coverage is 49.8%. Comparing base (0fba034) to head (4602fea).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
serlcd/serlcd.go 75.6% 25 Missing and 6 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #88     +/-   ##
=======================================
+ Coverage   49.5%   49.8%   +0.3%     
=======================================
  Files         90      91      +1     
  Lines      11736   11867    +131     
=======================================
+ Hits        5808    5908    +100     
- Misses      5674    5699     +25     
- Partials     254     260      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a few changes

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsexton gsexton merged commit cad2275 into periph:main Feb 9, 2025
10 checks passed
@gsexton gsexton deleted the SerLCD branch February 9, 2025 22:19
gsexton added a commit to gsexton/devices that referenced this pull request Feb 15, 2025
* Initial Creation
* Bump conn version
* add more documentation for 32 byte limit. minor code restructure to be more transparent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments