Fix superclass initializer false-positive when called on subclass #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a subclass inherits an initializer from its superclass, calling the initializer on the subclass (e.g., `Child(param: "foo")`) was not marking the superclass initializer as used, causing a false-positive. The index store records a relationship from the superclass initializer to the subclass implicit initializer, but not the inverse. Added a new mutator (InheritedImplicitInitializerReferenceBuilder) that creates the inverse reference so that when the implicit initializer is used, the superclass initializer is also marked as used. Fixes #957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subclass inherits an initializer from its superclass, calling the initializer on the subclass (e.g.,
Child(param: "foo")) was not marking the superclass initializer as used, causing a false-positive.The index store records a relationship from the superclass initializer to the subclass implicit initializer, but not the inverse. Added a new mutator (InheritedImplicitInitializerReferenceBuilder) that creates the inverse reference so that when the implicit initializer is used, the superclass initializer is also marked as used.
Fixes #957