Add gitlab-codequality formatting option #966
Open
+63
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I came across GitLabs
merge_requestdecorating capabilities - especially the code quality widget. It expects something very similar to CodeMagics JSON, however that misses a single property.I simply added a new formatter with near identical code as a first draft (because it's easy and fast). If someone thinks doing a bit more effort to deduplicate code, I'm happy to do so - wasn't sure for now.
One could also add the missing property to the existing
codeclimateformat option but I didn't want to break anything.I could also add an optional flag to let the user decide the severity?
Anyway, some feedback is highly appreciated!