Skip to content

Rename parameter to-perl to until-perl #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Rename parameter to-perl to until-perl #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ inputs:
description: "List all Perl versions since this (including this). Example: 5.10"
type: string
required: true
to-perl:
until-perl:
description: "List all Perl versions up to this (including this). Example: 5.30"
type: string
required: false
Expand Down
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ let available = [

try {
const since_perl = semver.coerce(core.getInput('since-perl'));
const to_perl_input = core.getInput('to-perl');
const to_perl = to_perl_input ? semver.coerce(to_perl_input) : null;
const until_perl_input = core.getInput('until-perl');
const until_perl = until_perl_input ? semver.coerce(until_perl_input) : null;
const with_devel = core.getInput('with-devel') == "true";

let filtered = available.filter(
Expand All @@ -23,7 +23,7 @@ try {
}
const version = semver.coerce(item);
const meetsLowerBound = semver.gte(version, since_perl);
const meetsUpperBound = !to_perl || semver.lte(version, to_perl);
const meetsUpperBound = !until_perl || semver.lte(version, until_perl);
return meetsLowerBound && meetsUpperBound;
}
);
Expand Down
Loading