Allow for enabling of USE_IMP_SYS in Win32 unthreaded builds. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled by merging of Perl/perl5#23178
|
@xenu, @jandubois, can you please review this pull request and then prepare a new CPAN release (which we would then merge into the Perl 5 core distribution)? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled by merging of Perl/perl5#23178 .
As of the merging of that PR, it is possible that an unthreaded Win32 build of perl has both USE_MULTI and USE_IMP_SYS defined.
The opening line of code in t/GetCurrentThreadId.t makes the (now) incorrect assumption that the perl is unthreaded because USE_IMP_SYS is defined.
This PR corrects that opening line by instead checking $Config{useithreads} for definedness.