Pod::Simple::XHTML: better fallback when HTML::Entities isn't installed#189
Pod::Simple::XHTML: better fallback when HTML::Entities isn't installed#189khwilliamson merged 1 commit intoperl-pod:masterfrom
Conversation
|
Added a test for this. Probably won't work under Perl 5.6, too bad. |
71bb8b9 to
c05b941
Compare
|
Fixed tests, they failed on most CI configurations, because I forgot to update the number of skipped tests in the case when HTML::Entities isn't installed. |
|
I would like the test to work on EBCDIC. Fortunately this is trivial to do. Just change the non-ASCII character to B6, and change the supporting text to correspond. One possibility would be. "The pilcrow, \xb6, is used to mark the beginning of a new paragraph" B6 is the only non-ASCII character that has the same meaning in Latin1 |
This commit changes the default set of escaped characters in the fallback code to be the same as in HTML::Entities. Fixes perl-pod#188
|
I went searching, and discovered HTML5::Entities which knows many more definitions than plain HTML::Entities. Should that be the default, with the plain being the first fallback? I also found Pod::Escapes, which ships with core since 5.12,, and automatically handles EBCDIC back to 5.7.3 which is good enough, and is available back to as far as we would ever need. Should this be another fallback? |
I'm not a fan of adding new dependencies to this module, I don't think it's worth it. Honestly, I really don't think entity handling in Pod::Simple::XHTML has to be super good. For encoding, it doesn't make any difference if we output
It's not a perfect fit, it doesn't provide a function equivalent to |
This commit changes the default set of escaped characters in the fallback code to be the same as in HTML::Entities.
Fixes #188