Skip to content

Restrict finds to displayed elements #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Restrict finds to displayed elements #7

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
625370e
Restrict finds to displayed
ylavoie Jul 17, 2017
928d887
Provide new entry to find all displayed only elements
ylavoie Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/Weasel/Driver/Selenium2.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,17 @@ sub stop {
$self->started(0);
}

=item find_all_displayed

=cut

sub find_all_displayed {
my $self = shift @_;
my @rv = $self->find_all(@_);
@rv = grep { $_->is_displayed } @rv;
Copy link
Contributor

@ehuelsmann ehuelsmann Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You yourself said that "is_displayed" is defined as "being part of the DOM". Then, what value does this function add?

Copy link
Contributor

@ehuelsmann ehuelsmann Feb 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylavoie ping

return wantarray ? @rv : \@rv;
}

=item find_all

=cut
Expand All @@ -183,7 +194,6 @@ sub find_all {
@rv = $_driver->find_child_elements($parent_id, $locator,
$scheme // 'xpath');
}
@rv = grep { $_->is_displayed } @rv;
return wantarray ? @rv : \@rv;
}

Expand Down