Skip to content

[Snyk] Security upgrade axios from 0.22.0 to 1.12.0 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade axios from 0.22.0 to 1.12.0 #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"dependencies": {
"@tinyhttp/app": "^1.3.7",
"apollo-server-express": "^2.25.0",
"axios": "^0.22.0",
"axios": "^1.12.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This axios upgrade from 0.22.0 to 1.12.0 is a major version change that introduces breaking changes. The current code uses axios in several resolvers (stories.ts, user.ts) and may be affected by API changes between these versions. You should verify that the existing axios usage patterns are still compatible with v1.x, particularly around response handling and error handling.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Breaking Change Risk: This upgrade spans multiple major versions (0.x to 1.x) and the PR description indicates it's a breaking change. Before merging, you should run comprehensive tests to ensure the application still functions correctly. Key areas to test include HTTP requests to the Hacker News API in the stories and user resolvers, error handling, and response data structure access patterns1.

Footnotes

  1. CWE-1104: Use of Unmaintained Third Party Components - https://cwe.mitre.org/data/definitions/1104.html ↩

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding axios types to your devDependencies if they're not already included. With axios v1.x, you may want to add @types/axios or verify that the built-in TypeScript definitions work correctly with your existing TypeScript code in the resolvers.

"body-parser": "^1.19.0",
"dotenv": "^10.0.0",
"graphql": "^15.5.0",
Expand Down