fix(mu,scheduler-utils): fix whitelist blocking and bundled process l…#1302
Closed
Lucifer0x17 wants to merge 1 commit intomainfrom
Closed
fix(mu,scheduler-utils): fix whitelist blocking and bundled process l…#1302Lucifer0x17 wants to merge 1 commit intomainfrom
Lucifer0x17 wants to merge 1 commit intomainfrom
Conversation
…ookup
- fix(mu): empty process whitelist (`{}`) was truthy, blocking all
messages with 403 when PROCESS_WHITELIST_URL is unset or fetch fails.
Added Object.keys check so empty whitelist means "allow all".
- fix(scheduler-utils): GraphQL tag filter `Data-Protocol=ao` in
loadProcessSchedulerWith does not match bundled data items (ANS-104)
on Arweave gateways, even when the tag exists. Removed filter from
query since we query by exact transaction ID, added code-level
validation for Data-Protocol=ao instead.
Author
|
This is addressed more gracfully by @VinceJuliano in a soeaerate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MU whitelist bug: When PROCESS_WHITELIST_URL is unset or fetch fails, fetchProcessWhitelist() returns {} which is truthy in JS. The check whitelist && !whitelist[target] evaluates to true for every process, blocking all messages
with 403. Fixed by adding Object.keys(whitelist).length > 0 guard.
the tag exists on the item. Removed the filter from the query (safe since we query by exact transaction ID) and added code-level validation for Data-Protocol=ao instead.
Test plan