fix: invert addTimeStamp config logic#130
Closed
oojacoboo wants to merge 1 commit intoperplorm:mainfrom
Closed
Conversation
The condition was inverted — `addTimeStamp: true` suppressed timestamps and `false` (the default) included them. This flips the condition so the config behaves as expected.
Collaborator
|
I am confused. This was already fixed in c08d88f (reference files don't work when timestamps are generated). Why is this showing up as changing something? Am I stupid this morning or what? |
Author
|
Oh, 2 days ago - wow okay. I think the issue is that my fork wasn't synced for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generator.objectModel.addTimeStampconfig option had inverted logic: setting it totruesuppressed timestamps, whilefalse(the default) included them.generateTimestampBlock()so the config behaves as its name suggests —trueadds timestamps,falseomits them.Note: the
baseQueryClassHeader.phptemplate already had the correct logic (if ($addTimestamp)→ show timestamp). This fix bringsAbstractOMBuilderin line with the template.Impact
Projects using the default
addTimeStamp: falsewill no longer get timestamps in generated class headers, eliminating unnecessary noise in version control diffs.