Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Methods
Model::setPrimaryKey()/Model::setPrimaryKeys()return void and are not chainable, even though everything else is.Changes
Methods return
$thisnow. This made some Spryker sniffs complain, so I removed them.Also, the script rebuilding reference files had to be adjusted for phpunit 10.
Implementation Details
First removed sniff required methods with
@return $thisto explicitly doreturn $this;. Returning$thisthrough another method (i.e.return $this->returnThis();) caused an error. This leads to unnecessarily elongated methods , and overall is something type checkers should handle, not linters.I remembered previously changing types from
@return $thisto@return staticbecause of this rule. I went back and adjusted those, now that the "correct" type can be used.Second removed sniff failed to recognize the array in
@param array{int, string}:Having array shapes seems more beneficial than what the rule checks, and I think this kind of error is detected by type checkers.
Test strategy
Via reference file and lint/stan.