Merged
Conversation
mringler
force-pushed
the
tests/always_close_statements
branch
from
0e085e1 to
c9c37d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests with sqlite kept failing with
Apparently, sqlite doesn't like it when data fetchers remain open, which happens
Now Formatters close their fetchers on exception and tests either close their statements or they are disabled on sqlite.
I wonder why this appeared all of a sudden. Usually I don't run Sqlite tests locally, never saw it on Github until #18 (which is completely unrelated). Turns out same error happened when I tried locally, but with all branches.
Error does occur in the file after the one that broke sqlite. Apparently the open statement keeps a lock on the db ile, which does not matter as long the connection remains open, but when it is reset during change of test class, the new connection fails at the second (I think) commit. This was a mfer to figure out.