Skip to content

Conversation

@kevin-fischer
Copy link

@kevin-fischer kevin-fischer commented Jan 26, 2026

Description

Restores the useMemo wrapper around transformData() that was accidentally removed in #415, fixing an infinite re-render loop that breaks sorting and filtering when table transforms are enabled.

Problem: When using table transforms (e.g., merge series) with sorting or filtering, the table becomes unresponsive due to infinite re-renders.

Root cause: Without memoization, transformData() executes on every render, creating a new data reference each time. This triggers React to re-render, which transforms again, creating an infinite loop.

Solution: Restore the useMemo wrapper with dependencies [rawData, spec.transforms] to ensure data is only recalculated when source data or transform configuration changes.

Fixes regression from #415

Screenshots

Before fix - Sorting broken with transforms

before-sorting-bug.mp4

After fix - Sorting works correctly

after-sorting-fixed.mp4

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC, IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

Signed-off-by: Kevin Fischer <49786038+kevin-fischer@users.noreply.github.com>
@kevin-fischer kevin-fischer requested a review from a team as a code owner January 26, 2026 04:55
@kevin-fischer kevin-fischer requested review from shahrokni and removed request for a team January 26, 2026 04:55
@jgbernalp jgbernalp enabled auto-merge January 26, 2026 07:31
@jgbernalp jgbernalp added this pull request to the merge queue Jan 26, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants