[BUGFIX] Table: restore data transform memoization #541
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restores the
useMemowrapper aroundtransformData()that was accidentally removed in #415, fixing an infinite re-render loop that breaks sorting and filtering when table transforms are enabled.Problem: When using table transforms (e.g., merge series) with sorting or filtering, the table becomes unresponsive due to infinite re-renders.
Root cause: Without memoization,
transformData()executes on every render, creating a new data reference each time. This triggers React to re-render, which transforms again, creating an infinite loop.Solution: Restore the
useMemowrapper with dependencies[rawData, spec.transforms]to ensure data is only recalculated when source data or transform configuration changes.Fixes regression from #415
Screenshots
Before fix - Sorting broken with transforms
before-sorting-bug.mp4
After fix - Sorting works correctly
after-sorting-fixed.mp4
Checklist
[<catalog_entry>] <commit message>naming convention using one of the followingcatalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes