make Persian module for recognize persian texts#14
Open
MohammadMobasher wants to merge 1 commit intopersian-tools:masterfrom
Open
make Persian module for recognize persian texts#14MohammadMobasher wants to merge 1 commit intopersian-tools:masterfrom
MohammadMobasher wants to merge 1 commit intopersian-tools:masterfrom
Conversation
nimahkh
reviewed
Jul 12, 2024
Collaborator
There was a problem hiding this comment.
Sorry for the late response, thanks so much for your effort,
May I kindly ask you to add the test, please?
nimahkh
requested changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
after searching to your repo, I figure out you don't have IsPersian function.
It's my pleasure to you accept my pull request ...
thanks