Map weights to CUDA or CPU depending on which is enabled#216
Merged
jjaime2 merged 2 commits intoros2-develfrom Mar 10, 2025
Merged
Map weights to CUDA or CPU depending on which is enabled#216jjaime2 merged 2 commits intoros2-develfrom
jjaime2 merged 2 commits intoros2-develfrom
Conversation
sriramk117
approved these changes
Mar 7, 2025
Contributor
sriramk117
left a comment
sriramk117
left a comment
There was a problem hiding this comment.
PR makes sense and code looks good to me
jjaime2
added a commit
that referenced
this pull request
Mar 15, 2025
jjaime2
added a commit
that referenced
this pull request
Mar 15, 2025
* Automatically download SPANet weights if not found * Run precommit * Automatically download SPANet weights if not found * Run precommit * Change SSH username to nano@nano (#200) * Map weights to CUDA or CPU depending on which is enabled (#216) * Automatically download SPANet weights if not found * Run precommit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check for whether CUDA is enabled before loading our checkpoint weight files. If it isn't enabled, we map the weights to CPU instead. This is particularly relevant since the current instructions for setting up machines to run
ada_feedingdoesn't explicitly require enabling CUDA.Testing procedure
lovelaceand one of the lab machinesBefore opening a pull request
pre-commit run --all-filespylint --recursive=y --rcfile=.pylintrc .. All warnings butfixmemust be addressed.Before Merging
Squash & Merge