Add pre-commit routines for prettier formatting on Xacro, launch and package XML files#58
Merged
Add pre-commit routines for prettier formatting on Xacro, launch and package XML files#58
Conversation
yewon-lee
previously requested changes
Mar 14, 2025
yewon-lee
left a comment
yewon-lee
left a comment
There was a problem hiding this comment.
Looks good, just left one comment for .pre-commit-config.yaml.
sriramk117
approved these changes
Mar 14, 2025
jjaime2
dismissed
yewon-lee’s stale review
I addressed the requested change, just dismissing the request because it didn't do it automatically when I pushed the commit for some reason
gurnoork07
pushed a commit
to studiorobot/ada_ros2
that referenced
this pull request
Nov 29, 2025
…package XML files (personalrobotics#58) * Add pre-commit check for prettier formatting on Xacro, launch and package XML files * Run pre-commit * Update repo for Xacro pre-commit hooks, now points to PRL repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a pre-commit routine for prettier formatting on Xacro, launch and package XML files. Resolves #56
You must run
npm install --save-dev prettier @prettier/plugin-xmlprior topre-commit run --all-filesto run prettier with the XML plugin.Note to reviewers: You don't need to read all the thousands of changed lines, just skim through and notice that our Xacro is actually readable now :)
Testing procedure
This PR does not introduce any fundamental changes to the behavior of the code, it just updates formatting
Before opening a pull request
pre-commit run --all-filespylint --recursive=y --rcfile=.pylintrc .. All warnings butfixmemust be addressed.Before Merging
Squash & Merge