Skip to content

Check pyarrow import and make clear(er) error message #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
texodus merged 1 commit into from
Nov 18, 2024
Merged

Check pyarrow import and make clear(er) error message #2848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions rust/perspective-python/src/client/pandas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

use pyo3::exceptions::PyValueError;
use pyo3::exceptions::{PyImportError, PyValueError};
use pyo3::prelude::*;
use pyo3::types::{PyAny, PyBytes, PyDict, PyList};

Expand Down Expand Up @@ -61,7 +61,15 @@ pub fn pandas_to_arrow_bytes<'py>(
py: Python<'py>,
df: &Bound<'py, PyAny>,
) -> PyResult<Bound<'py, PyBytes>> {
let pyarrow = PyModule::import_bound(py, "pyarrow")?;
let pyarrow = match PyModule::import_bound(py, "pyarrow") {
Ok(pyarrow) => pyarrow,
Err(_) => {
return Err(PyImportError::new_err(
"Perspective requires pyarrow to convert pandas DataFrames. Please install pyarrow.",
))
}
};

let df_class = get_pandas_df_cls(py)?
.ok_or_else(|| PyValueError::new_err("Failed to import pandas.DataFrame"))?;

Expand Down
Loading