Skip to content

Fixed issue with comments #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brammittendorff merged 1 commit into from
Apr 2, 2025
Merged

Fixed issue with comments #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,10 @@ jobs:
context: .
# Load image into Docker daemon for local testing, don't push
load: true
# Use a distinct tag for the test build image
tags: local/gpt-po-translator:py${{ matrix.python-version }}-test
build-args: |
PYTHON_VERSION=${{ matrix.python-version }}
VERSION=${{ steps.get_version.outputs.VERSION }}
# Use distinct cache scope for test build
cache-from: type=gha,scope=test-${{ matrix.python-version }}
cache-to: type=gha,mode=max,scope=test-${{ matrix.python-version }}

Expand Down Expand Up @@ -195,7 +193,7 @@ jobs:
permissions:
contents: read # For checkout
packages: write # For GHCR push
id-token: write # Uncomment if using PyPI Trusted Publishing`
# id-token: write # Uncomment if using PyPI Trusted Publishing`

strategy:
fail-fast: true # If one deployment fails, stop others
Expand Down Expand Up @@ -309,8 +307,7 @@ jobs:
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
build-args: |
PYTHON_VERSION=${{ matrix.python-version }} # From the matrix
VERSION=${{ steps.get_version_tag.outputs.VERSION }} # From the Git tag
# Use cache specific to deployment and python version
PYTHON_VERSION=${{ matrix.python-version }}
VERSION=${{ steps.get_version_tag.outputs.VERSION }}
cache-from: type=gha,scope=deploy-${{ matrix.python-version }}
cache-to: type=gha,mode=max,scope=deploy-${{ matrix.python-version }}
Loading