-
Notifications
You must be signed in to change notification settings - Fork 12
Add Azure OpenAI as provider #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @vbossica, Thanks for adding Azure OpenAI support! A few things to fix before merging:
The implementation looks good overall, just need these tweaks to maintain code quality. Feel free to ask if you have questions about any of these. And if you need help just ask, we are happy to help. P.s. you can leave your name in the code if you want 👯 |
|
Hey @vbossica, Actually, if you're done with option 3 (the tests), we're fine with that and we can split the model manager afterwards. No need to hold up the PR for the refactoring. Thanks for being so responsive to the feedback. |
|
@pescheck-bram Done! I had to remove some typing because Python 3.8 didn't like it. But since 3.8 is EOL, maybe removing it from the supported versions would make sense. |
|
Good one ticket created: #46 Merge request looks good to me! |
No description provided.