Skip to content

Conversation

@chrispage1
Copy link

Q A
Bug fix? yes
New feature? yes
Fixed tickets #1433

This PR adds a concern that allows users to bypass domain based routing validation. This was born out of v4 browser tests failing because of domain specific routing.

As much as I'd love to contribute to the main Pest repo, I've added it here as it seems like the most logical place, given that its overriding Laravel functionality.

Example use case:

<?php

uses (Pest\Laravel\Concerns\BypassesDomainRouting::class);

it('can navigate to a domain based route', function () {
    visit(route('domain-based-route'))
      ->assertSee('It works!');
});

Please let me know if you think my design choice to add this into a Concerns directory is not correct and you'd like it elsewhere.

I've also added testing into this to ensure it wouldn't break existing overrides that anyone may have added to their code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant