Fix dotnet-sign auth: add GitHub environment + remove redundant WIF flags#389
Merged
Aaronontheweb merged 1 commit intodevfrom Feb 24, 2026
Merged
Fix dotnet-sign auth: add GitHub environment + remove redundant WIF flags#389Aaronontheweb merged 1 commit intodevfrom
Aaronontheweb merged 1 commit intodevfrom
Conversation
- Add `environment: signing` to the release job so the OIDC token subject matches the federated credential subject (repo:petabridge/TurboMqtt:environment:signing) - Remove --azure-key-vault-client-id and --azure-key-vault-tenant-id flags from the Sign step; azure/login handles OIDC auth and dotnet sign picks up credentials automatically via DefaultAzureCredential/AzureCliCredential - Add -v Information for better signing step visibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environment: signingto the release job so the OIDC token subject matches the federated credential (repo:petabridge/TurboMqtt:environment:signing)--azure-key-vault-client-idand--azure-key-vault-tenant-idfrom thesignstep —azure/loginhandles OIDC auth anddotnet signpicks up credentials automatically viaDefaultAzureCredential/AzureCliCredential-v Informationfor signing step visibilityAzure-side prerequisites (already completed):
signingcreated onpetabridge/TurboMqttgha-turbomqtt-signingcreated on theCodeSignermanaged identity with subjectrepo:petabridge/TurboMqtt:environment:signingTest plan
1.0.0) to trigger the release workflowsigningenvironment badge in the Actions UIAzure loginstep succeeds (OIDC exchange)Sign NuGet packagesstep completes without auth errors.nupkgfiles are pushed to NuGet.org and attached to the GitHub Release