Skip to content

minimalcss takes into account css from iframe #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

minimalcss takes into account css from iframe #331

wants to merge 1 commit into from

Conversation

peterbe
Copy link
Owner

@peterbe peterbe commented Sep 19, 2019

Fixes #206

@peterbe
Copy link
Owner Author

peterbe commented Sep 19, 2019

I don't know if it's good enough to check that the domains are different. If you have a page like:

<body>
  <iframe src="/page.html"></iframe>
</body>

this test would "fail". But how likely is that??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stereobooster stereobooster Awaiting requested review from stereobooster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minimalcss takes into account css from iframe
1 participant
@peterbe