Skip to content

Set longer fetch timeout for SHA/tag response #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Set longer fetch timeout for SHA/tag response #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
684ea99
Format deployment error output
janbrasna Apr 26, 2025
25a1515
Add 30s timeout for deployment shas & tags
janbrasna Apr 26, 2025
8d603d2
Add disjunct SHA info to error message
janbrasna Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def post(self):
sha = extract_sha(content)
if not sha:
# doesn't appear to be a git sha
error = "Doesn't look like a sha\n (%s) on %s" % (content, each["url"])
error = "Doesn't look like a sha:\n (“%s”)\n — on: %s" % (content, each["url"])
return make_response(jsonify({"error": error}))

deployments.append({"name": name, "sha": sha, "bugs": [], "url": url})
Expand Down
13 changes: 9 additions & 4 deletions src/DeployPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,11 @@ class DeployPage extends React.Component {
this.startLoad('shas');
try {
const res = await ky
.post('/shas', { json: { owner, repo, deployments } })
.post('/shas', {
json: { owner, repo, deployments },
retries: 3,
timeout: 30000,
})
.json();

if (res.error) {
Expand All @@ -94,7 +98,7 @@ class DeployPage extends React.Component {
});
}
} catch (error) {
console.warn('Error fetching shas!');
console.warn('Error fetching deployment /shas or tags!');
console.error(error);
this.setState({ error });
} finally {
Expand Down Expand Up @@ -175,7 +179,7 @@ class DeployPage extends React.Component {
</>
) : !deployInfo ? (
<div className="alert alert-danger">
No Deployment info could be found
Deployment info could not be retrieved
</div>
) : (
<>
Expand Down Expand Up @@ -351,7 +355,8 @@ class DeployTable extends React.Component {
) : (
<div className="alert alert-warning" role="alert">
Even after comparing the last {commits.length} commits, a common
denominator could not be found! The difference is just too big.
denominator could not be found! The difference is just too big,
or the deployment SHA does not come from the default branch.
<br />
Use the links below to compare directly on GitHub.
</div>
Expand Down