Skip to content

Add attachmentPreview for MessageComposerView #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2025
Merged

Add attachmentPreview for MessageComposerView #14

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cb4a3a5
add attachment preview
YoungHypo Aug 17, 2025
00275fb
chang userPrompt to message
YoungHypo Aug 17, 2025
6d6400b
delete imageURL in message protocol
YoungHypo Aug 17, 2025
6d55863
make imageURL optional
YoungHypo Aug 18, 2025
7ca89a2
fix typo
YoungHypo Aug 18, 2025
0de0b8c
fix typo
YoungHypo Aug 18, 2025
18a21ed
restore Message protocol
YoungHypo Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 38 additions & 24 deletions Sources/ConversationKit/Views/MessageComposerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ extension EnvironmentValues {
@Entry var onSubmitAction: () -> Void = {}
@Entry var disableAttachments: Bool = false
@Entry var attachmentActions: AnyView = AnyView(EmptyView())
@Entry var attachmentPreview: AnyView = AnyView(EmptyView())
}

extension View {
Expand All @@ -36,13 +37,18 @@ extension View {
public func attachmentActions<Content: View>(@ViewBuilder content: () -> Content) -> some View {
environment(\.attachmentActions, AnyView(content()))
}

public func attachmentPreview<Content: View>(@ViewBuilder content: () -> Content) -> some View {
environment(\.attachmentPreview, AnyView(content()))
}
}

public struct MessageComposerView: View {
@Environment(\.onSubmitAction) private var onSubmitAction
@Environment(\.disableAttachments) private var disableAttachments
@Environment(\.attachmentActions) private var attachmentActions

@Environment(\.attachmentPreview) private var attachmentPreview

@Binding var message: String

public init(message: Binding<String>) {
Expand All @@ -63,18 +69,22 @@ public struct MessageComposerView: View {
.controlSize(.large)
.buttonBorderShape(.circle)
}

VStack {
attachmentPreview

HStack(alignment: .bottom) {
TextField("Enter a message", text: $message, axis: .vertical)
.frame(minHeight: 32)
.padding(EdgeInsets(top: 7, leading: 16, bottom: 7, trailing: 0))
.onSubmit(of: .text) { onSubmitAction() }

Button(action: { onSubmitAction() }) {
Image(systemName: "arrow.up")
HStack(alignment: .bottom) {
TextField("Enter a message", text: $message, axis: .vertical)
.frame(minHeight: 32)
.padding(EdgeInsets(top: 7, leading: 16, bottom: 7, trailing: 0))
.onSubmit(of: .text) { onSubmitAction() }

Button(action: { onSubmitAction() }) {
Image(systemName: "arrow.up")
}
.buttonStyle(.borderedProminent)
.padding(EdgeInsets(top: 7, leading: 0, bottom: 7, trailing: 7))
}
.buttonStyle(.borderedProminent)
.padding(EdgeInsets(top: 7, leading: 0, bottom: 7, trailing: 7))
}
.glassEffect(.regular.interactive(), in: .rect(cornerRadius: 20.0))
.offset(x: -5.0, y: 0.0)
Expand All @@ -101,20 +111,24 @@ public struct MessageComposerView: View {
)
.padding(.trailing, 8)
}

HStack(alignment: .bottom) {
TextField("Enter a message", text: $message, axis: .vertical)
.frame(minHeight: 32)
.padding(EdgeInsets(top: 6, leading: 16, bottom: 6, trailing: 0))
.onSubmit(of: .text) { onSubmitAction() }

Button(action: { onSubmitAction() }) {
Image(systemName: "arrow.up")

VStack {
attachmentPreview

HStack(alignment: .bottom) {
TextField("Enter a message", text: $message, axis: .vertical)
.frame(minHeight: 32)
.padding(EdgeInsets(top: 6, leading: 16, bottom: 6, trailing: 0))
.onSubmit(of: .text) { onSubmitAction() }

Button(action: { onSubmitAction() }) {
Image(systemName: "arrow.up")
}
.buttonStyle(.borderedProminent)
.buttonBorderShape(.circle)
.controlSize(.regular)
.padding(EdgeInsets(top: 6, leading: 0, bottom: 6, trailing: 7))
}
.buttonStyle(.borderedProminent)
.buttonBorderShape(.circle)
.controlSize(.regular)
.padding(EdgeInsets(top: 6, leading: 0, bottom: 6, trailing: 7))
}
.background(.regularMaterial)
.clipShape(RoundedRectangle(cornerRadius: 22))
Comment on lines +115 to 134
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is significant code duplication between this block (for older iOS versions) and the one inside the #if #available(iOS 26.0, *) check (lines 73-90). The layout logic for the VStack containing attachmentPreview and the HStack for the text input is nearly identical.

To improve maintainability, consider refactoring the common view structure into a private @ViewBuilder method or property. This would centralize the layout logic and make future changes easier to apply across both platform-specific branches.

Expand Down