Skip to content

Conversation

@acs027
Copy link

@acs027 acs027 commented Oct 1, 2025

Make attachmentActions optional to simplify checking for actions
Add an attachment action to the preview for demonstration
Add a preview showing the composer without attachment actions

…ese#11

Add an attachment action to the preview for demonstration.
@gemini-code-assist
Copy link

Summary of Changes

Hello @acs027, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the MessageComposerView by introducing optionality for attachment actions. This change ensures that the UI element for attachment actions, typically a 'plus button', is only visible when actual actions are registered, thereby improving the user experience and simplifying the component's logic. The accompanying preview updates clearly demonstrate this new conditional behavior.

Highlights

  • Attachment Actions Optional: The attachmentActions environment value has been updated from AnyView to AnyView?, making it optional. This allows for a clear distinction between no actions being registered versus an empty set of actions.
  • Conditional Plus Button Display: The 'plus button' (which triggers the attachment actions menu) in the MessageComposerView will now only be displayed if attachment actions are explicitly provided (i.e., attachmentActions is not nil) and attachments are not disabled.
  • Enhanced Previews: The pull request includes an update to an existing preview to demonstrate how to register an attachment action, and introduces a new preview specifically showing the MessageComposerView without any registered attachment actions, illustrating the hidden plus button.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively hides the attachment button when no actions are provided by making attachmentActions optional. The implementation is clean, and the addition of previews for both scenarios is a great improvement. I have one high-severity concern regarding an availability check that appears to be incorrect or at least confusing, which could lead to unexpected UI behavior on different OS versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant