Merged
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JRuby doesn't support the _ modifier after q (64-bit) type. Use fixed-size formats ll (8 bytes) and qq (16 bytes) instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use private_method_defined? instead of private_instance_methods.include? Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add interleaved read/write for pipelined gets to prevent socket buffer deadlock when fetching many keys. For batches over 10,000 keys per server, requests are now sent in chunks with response draining between chunks. This prevents the scenario where the client's send buffer fills up waiting for the server to read, while the server's send buffer fills up waiting for the client to read, causing deadlock. Key changes: - Add pipelined_get_interleaved method that writes in chunks and drains - Add drain_pipeline_responses for non-blocking response collection - Add ensure_ready to ResponseBuffer to preserve partial buffered data - Pass results hash directly to avoid allocation/merge overhead Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When using `raw: true`, only String values are now accepted. Previously,
non-string values were silently converted via `to_s`, causing issues like
`nil` becoming `""` and integers losing their type information.
This matches the behavior of client-level `raw: true` mode (StringMarshaller)
and aligns with the expectation that raw mode means "pass-through, no magic".
Breaking change: `set(key, nil, raw: true)` and `set(key, 123, raw: true)`
now raise MarshalError. Use string values for counters: `set('counter', '0', raw: true)`.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Clear response buffer at start of pipelined_get to remove stale data from interrupted operations. Uses clear() instead of reset() to maintain proper pipeline state detection (pipeline_complete? remains true until pipeline_response_setup is called). This fixes intermittent test failures on JRuby where Thread#raise or Thread#kill during get_multi could leave corrupted buffer data that affected subsequent operations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Prevents cancelled jobs from appearing as failures when new pushes cancel in-progress workflows. Each workflow now uses a unique concurrency group based on the branch/PR reference. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Benchmarks take ~4 minutes to run. When multiple commits are pushed during development, previous runs get cancelled and show as failures. Changed to only run benchmarks on: - Pushes to main (after PR merge) - Manual trigger via workflow_dispatch This ensures benchmark data is collected for released code without causing false failures during development. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1034 - Timeval Architecture Fix ✅
#1019 - Configurable Namespace Separator ✅