Add resolv-replace compatibility test
#998
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
force-pushed
the
resolv-replace-regression-test
branch
3 times, most recently
from
9fc690a to
09dea6d
Compare
While `dalli` doesn't depend on `resolv-replace`, we want to ensure it still works if it is required by the host application. This regression test ensures we don't break compatibility, and adds a framework allowing us to test compatibility with other gems in the future.
sambostock
force-pushed
the
resolv-replace-regression-test
branch
from
09dea6d to
610a4b9
Compare
sambostock
commented
Mar 8, 2024
Comment on lines
+3
to
+4
| # JRuby does not support forking, and it doesn't seem worth the effort to make it work. | ||
| return unless Process.respond_to?(:fork) |
Contributor
Author
There was a problem hiding this comment.
Active Support has some workarounds for this we could use, but it doesn't seem worth it for a code path that was previously untested, and is unlikely to behave differently on JRuby.
| ].each do |gem_name| | ||
| it "passes smoke test with #{gem_name.inspect} gem required" do | ||
| memcached(:binary, rand(21_397..21_896)) do |_, port| | ||
| in_isolation(timeout: 10) do |
Contributor
Author
There was a problem hiding this comment.
We want to be able to require the gem in isolation so as not to affect the host process and other tests.
| assert_equal(expected, client.get(key), message) | ||
| end | ||
|
|
||
| def in_isolation(timeout:) # rubocop:disable Metrics |
Contributor
Author
There was a problem hiding this comment.
This method triggers several offences in the Metrics department, but I don't know that splitting it would be an improvement.
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
dallidoesn't depend onresolv-replace, we want to ensure it still works if it is required by the host application. (#989)This regression test ensures we don't break compatibility, and adds a framework allowing us to test compatibility with other gems in the future.