Skip query hits above user-defined threshold#147
Open
nuno-agostinho wants to merge 2 commits intopeterjc:masterfrom
Open
Skip query hits above user-defined threshold#147nuno-agostinho wants to merge 2 commits intopeterjc:masterfrom
nuno-agostinho wants to merge 2 commits intopeterjc:masterfrom
Conversation
Owner
|
Interesting - it reminds me of how I used to use https://github.com/peterjc/galaxy_blast/tree/master/tools/blastxml_to_top_descr but yours is more general. I feel this could be the start of a slippery slope, morphing from XML to tabular conversion, into BLAST result filtering. It might be better to implement a separate BLAST filtering tool? But then which format(s) would you want to be able to filter? Hmm. Either way, I've not been using Galaxy recently and really need to look at #140 before risking any non-trivial update to the wrappers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thanks for writing blastxml_to_tabular.py!
It does almost everything I need. However, as I only care about the top hits, I added an option to filter the number of hits returned based on
Hit_numfrom the XML input file (by default, nothing is filtered).I opened this PR in case you find that these changes may be helpful to other users.
Best regards,
Nuno