Manifests can point at local test-data folders now#150
Open
Manifests can point at local test-data folders now#150
Conversation
Contributor
|
I would suggest to do this 1 PR per tool / tool collection. There will probably to many lint and test errors to keep it manageable, or? |
Owner
Author
|
I think the strip components setting would explain the otherwise mystifying errors like this: |
peterjc
force-pushed
the
simpler_manifests
branch
from
5c6ad89 to
9e9caad
Compare
As of #149, each tool has its own test-data/ folder (currently a symlink to the top level shared folder). This means the manifest no longer needs to point at the top level folder. $ sed -i.bak "s#../../test-data/#test-data/#g" tools/*/.shed.yml
This was sensible for consistency with the top-level shared tool-data and test-data folders, but we're phasing that out to follow IUC standard layout
Now using per-tool sub-folders as per IUC recommended layout.
peterjc
force-pushed
the
simpler_manifests
branch
from
9e9caad to
0f09fcc
Compare
Owner
Author
|
Seems 940f223 has not worked to skip problematic tests... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #149, each tool has its own test-data/ folder (currently a symlink to the top level shared folder). This means the manifest no longer needs to point at the top level folder.