Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the Images package from 0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21, 0.22, 0.23, 0.24 to 0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21, 0.22, 0.23, 0.24, 0.25.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@peterkovesi peterkovesi force-pushed the compathelper/new_version/2021-11-26-00-27-55-543-00307814880 branch from d4ff7f8 to 230966e Compare November 26, 2021 00:28
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #27 (230966e) into master (6b64aaa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   44.33%   44.33%           
=======================================
  Files           8        8           
  Lines        1985     1985           
=======================================
  Hits          880      880           
  Misses       1105     1105           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b64aaa...230966e. Read the comment docs.

@johnnychen94
Copy link

I haven't yet looked into the codes, but it's perhaps also doable to remove the Images dependency.

@johnnychen94
Copy link

I noticed an ancient usage Images.Image in

return Images.Image(cimg, prop)
; this no longer exists.

The test coverage is only 44%, my best guess is that a large portion of functionalities in this package are broken already. So to upgrade this package I think we need some rewrite of the basic functions first.
Simply adding Images v0.25 to the Project.toml won't make anything better.

@peterkovesi
Copy link
Owner

I agree the test coverage is rather woeful. I need to carefully step through each function removing ancient usage and improving the testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants