Handle unknown HTTP error codes

[petermcd]

Summary

• avoid KeyError for unexpected HTTP responses in HttpIO
• add regression test for unhandled status codes

Testing

• pytest -q (fails: fixture 'mocker' not found)
• pytest tests/test_httpio_errors.py -q

---

https://chatgpt.com/codex/tasks/task_e_689e59275398832488df20e590145ae8

Summary by Sourcery

Handle unknown HTTP status codes without raising KeyError by defaulting to MonzoGeneralError and add a regression test

Bug Fixes:

• Map unexpected HTTP error codes to MonzoGeneralError to avoid KeyError

Tests:

• Add regression test to verify that unknown HTTP status codes raise MonzoGeneralError

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

HttpIO now handles unexpected HTTP error codes by falling back to MonzoGeneralError instead of raising a KeyError, and a new regression test ensures this behavior.

Sequence diagram for handling unknown HTTP error codes in HttpIO

sequenceDiagram
    participant HttpIO
    participant HTTPError
    participant MONZO_ERROR_MAP
    participant MonzoGeneralError
    HttpIO->>HTTPError: perform request
    HTTPError-->>HttpIO: raise error with code
    HttpIO->>MONZO_ERROR_MAP: get exception for error.code
    alt error.code in MONZO_ERROR_MAP
        MONZO_ERROR_MAP-->>HttpIO: return mapped exception
        HttpIO->>HttpIO: raise mapped exception
    else error.code not in MONZO_ERROR_MAP
        MONZO_ERROR_MAP-->>HttpIO: return MonzoGeneralError
        HttpIO->>MonzoGeneralError: raise MonzoGeneralError
    end

Loading

Class diagram for updated HTTP error handling in HttpIO

classDiagram
    class HttpIO {
        +_perform_request()
    }
    class HTTPError {
        +code
    }
    class MONZO_ERROR_MAP {
    }
    class MonzoGeneralError {
    }
    HttpIO --> HTTPError : handles
    HttpIO --> MONZO_ERROR_MAP : uses
    MONZO_ERROR_MAP --> MonzoGeneralError : fallback

Loading

File-Level Changes

Change	Details	Files
Handle unknown HTTP error codes with fallback to MonzoGeneralError	Use MONZO_ERROR_MAP.get with MonzoGeneralError as default Assign the resulting exception class to a variable before raising	monzo/httpio.py
Add regression test for unhandled HTTP status codes	Simulate an HTTPError with an unknown status code via patching Assert that MonzoGeneralError is raised in this scenario	tests/test_httpio_errors.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}