Add authentication error tests for empty and mismatched tokens

[petermcd]

Summary

• test that Authentication.authenticate raises MonzoAuthenticationError when authorization token is missing
• test that mismatched state tokens trigger MonzoAuthenticationError

Testing

• pytest tests/test_authentication.py::TestEndPoints::test_authenticate_state_token_mismatch -q (fails: fixture 'mocker' not found)

---

https://chatgpt.com/codex/tasks/task_e_689e5a36c31083249bfd8dbb38de81ae

Summary by Sourcery

Add tests to verify that Authentication.authenticate raises MonzoAuthenticationError when the authorization token is empty or when the provided state token does not match the expected token.

Tests:

• Add test_authenticate_with_empty_token to assert an error is raised for empty authorization tokens
• Add test_authenticate_state_token_mismatch to assert an error is raised for mismatched state tokens

[sourcery-ai]

Reviewer's Guide

Enhances authentication test coverage by adding two pytest cases that verify MonzoAuthenticationError is raised when the authorization token is empty and when the supplied state token does not match the expected value, leveraging pytest.raises and mocking gettempdir for state persistence.

File-Level Changes

Change	Details	Files
Add test for empty authorization token error	Introduce test_authenticate_with_empty_token method Instantiate Authentication with blank token Assert MonzoAuthenticationError on authenticate with empty authorization_token	tests/test_authentication.py
Add test for mismatched state token error	Patch gettempdir to control state persistence location Retrieve auth.state_token and append invalid suffix Assert MonzoAuthenticationError on authenticate with mismatched state_token	tests/test_authentication.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}