Fix Emscripten 3.1.74+ compatibility and all test failures #103
+573
−627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace writeArrayToMemory calls with Module.HEAPU8.set() in post.js and post-async.js - Add HEAPU8 to EXPORTED_RUNTIME_METHODS for browser compatibility - Fixes compatibility with Emscripten 3.1.74+ where writeArrayToMemory is no longer available by default - All browser tests now pass with Emscripten 4.0.13 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix callWithOutput to properly capture and throw exit codes - Now captures the exit code returned by Module.callMain() - Throws error with exit code when command fails - Fixes git checkout and conflicts tests - Fix nodefs test cleanup - Use clonedir variable instead of string literal in rmSync - Properly removes the test directory after test completes All 6 Node.js tests now pass with Emscripten 4.0.13 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…ject status - Add compatibility section with supported versions - Expand "Building and developing" section with: - Prerequisites list - Step-by-step Quick Start guide - Clear build commands for all variants (Debug/Release, sync/async) - npm dependencies and test commands - Development options (Codespaces and local) - Build outputs location - Current test status (all passing!) - Troubleshooting section for common issues - Fix typo in test-browser-async link - Update to reflect compatibility with Emscripten 4.0.13 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
petersalomonsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes compatibility issues with modern Emscripten versions (3.1.74+) and resolves all test failures.
Changes:
writeArrayToMemorydeprecation - Replace withModule.HEAPU8.set()for Emscripten 3.1.74+ compatibilitycallWithOutputfunctionTesting
All tests are now passing with Emscripten 4.0.13:
npm test- All 6 Node.js tests passingnpm run test-browser- All 18 browser tests passingnpm run test-browser-async- Async version works correctlyCompatibility
Breaking Changes
None - all changes maintain backward compatibility.
🤖 Generated with Claude Code