Skip to content

Conversation

@paul-jarrow
Copy link

@paul-jarrow paul-jarrow commented Oct 16, 2025

This is a simple fix for posix systems like macOS. The setup script lands on an error for sed commands when using the -i flag. I'm able to successfully run those sed commands when I add the fix myself.

To test:

Please ensure that this is tested on other systems! (Linux, Windows, as necessary)

  1. Perform the setup as described in the README
  2. Note that when you perform the step that instructs you to run the setup script, ./setup.sh, an error occurs on the last two steps, those which perform a sed text replace.
  3. Note that with this change, you should see the last two steps succeed.
  4. You can confirm that the last two steps worked if it successfully changes the files libgit2/src/libgit2/pack.h and libgit2/src/libgit2/odb.h with the replacement strings, GIT_PACK_FILE_MODE 0444 -> GIT_PACK_FILE_MODE 0644 and GIT_OBJECT_FILE_MODE 0444 -> GIT_OBJECT_FILE_MODE 0644 respectively.

resolves #106

@petersalomonsen
Copy link
Owner

petersalomonsen commented Oct 23, 2025

@paul-jarrow Thanks for the Pull Request. I did just run the status checks, and it seems like it breaks in the github action ( which runs on Linux ):

image

Also, consider adding a github action workflow for macos to verify that it builds there as well ( which will show that your change works )

@paul-jarrow paul-jarrow closed this by deleting the head repository Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using setup.sh on POSIX compliant Unix systems (e.g. macOS)

2 participants