Add lexer and parser generator script #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
force-pushed
the
patch-lexers-parsers
branch
3 times, most recently
from
62ff762 to
2be4310
Compare
petk
force-pushed
the
patch-lexers-parsers
branch
2 times, most recently
from
26aff0c to
d75ef41
Compare
This improves usability to simply call:
cmake -P cmake/scripts/GenerateLexersParsers.cmake
instead of doing the entire CMake configuration phase and then executing
some target to generate files.
- This adds new BISON and RE2C utility modules on top of the find modules to have common configuration at one place. - Zend patching improved a bit - More common naming for lexers and parsers used in filenames: "grammar" - ...
The --conditions option is available since re2c 1.1.
Find modules are not meant to provide functions. This is an edge bad practice learned from some existing modules out there for convenience. Find modules should ideally only deal with finding packages and providing the imported targets. Ideally, how the package is used should be done in some wrapper module, which provides these functions. Here, the php_bison() and php_re2c(). Also, downloading is moved to these modules for now.
This simplifies downloading, configuring etc. The Bison downloading and configuring for now works only for GNU Bison. Should be improved further.
petk
force-pushed
the
patch-lexers-parsers
branch
from
d75ef41 to
0532a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves usability to simply call:
instead of doing the entire CMake configuration phase and then executing some target to generate files.