Fix ext/odbc and ext/pdo_odbc #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated FindODBC module - Configuration options synced - User experience annoyances reduced a bit - Configuration headers synced for in-php-src or standalone extension builds
- MySQL_CONFIG_EXECUTABLE marked as advanced to not show in regular list of options in GUI - PHP/Set module adjusted to have choices validated by default - Fixed odbc extension build as these are still STATIC libraries for simplicity of usage but should probably be OBJECT otherwise PHP doesn't provide some symbols when linking.
* Simplified `CHOICES` handling and automatic set of `VALUE` and `TYPE` * When using `PkgConfig` `pkg_*` commands, the `PkgConfig` module can also not be loaded when `CMAKE_DISABLE_FIND_PACKAGE_PkgConfig` is set by the user. This syncs `FindODBC` and the rest of the `Find*` modules with `PKG_CONFIG_FOUND` guards. * Rest of the extensions synced with the new `php_set()` signature.
This check is a bit simplistic but it matches the upstream check. Many of these headers are not self-contained and can't be checked with only check_include_file so this resorts to file checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP/Setmodule with more functionality