An explicit test of correct and incorrect grant addition#217
Closed
maximmasiutin wants to merge 1 commit intopetoju:masterfrom
Closed
An explicit test of correct and incorrect grant addition#217maximmasiutin wants to merge 1 commit intopetoju:masterfrom
maximmasiutin wants to merge 1 commit intopetoju:masterfrom
Conversation
maximmasiutin
force-pushed
the
feature/different-privileges-test
branch
11 times, most recently
from
921b439 to
3cb5ce0
Compare
maximmasiutin
force-pushed
the
feature/different-privileges-test
branch
from
c2f7350 to
8fac9eb
Compare
… privilege on `*` to coexist with database-specific grants; added MySQL 8.4.5 in the test cases, and changed Terraform version to 1.11.3; also added a manual test for multiple providers in different database instances (to ensure that the objects in different providers do not conflict)
maximmasiutin
force-pushed
the
feature/different-privileges-test
branch
from
515e6c6 to
d98b3a0
Compare
petoju
reviewed
Apr 22, 2025
| @@ -0,0 +1,8 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| cd test1 || exit 1 | |||
Owner
There was a problem hiding this comment.
For other changes, I understand them - but how would these scripts and directory test help?
Generally, tests inside *_test.go are much better idea - terraform testing harness catches more issues than executing something manually.
Contributor
Author
|
The changes in "test" are actually not needed - they were to demonstrate working with two providers (two instances). I didn't know how to make that with the GNU makefile. Let me create another pull request without these files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.