Skip to content

feat: reproduced the uppercase grants of column names with reserved keywords#247

Merged
petoju merged 1 commit intopetoju:masterfrom
maximmasiutin:fix/uppercase-grants
Aug 6, 2025
Merged

feat: reproduced the uppercase grants of column names with reserved keywords#247
petoju merged 1 commit intopetoju:masterfrom
maximmasiutin:fix/uppercase-grants

Conversation

@maximmasiutin
Copy link
Contributor

Reproduces #246

…olumn names cause permission error because by default collation in column names is binary; (2) added case-insensitive comparison for permissions
@maximmasiutin
Copy link
Contributor Author

@petoju all tests passed; I made case-insensitive comparison for grants and removed conversion of grants to uppercase because it gave access denied for binary collation; I also added a test for SELECT and column-level grants to illustrate the issue; this test passes.

@petoju petoju merged commit 56256c3 into petoju:master Aug 6, 2025
15 checks passed
@petoju
Copy link
Owner

petoju commented Aug 6, 2025

@maximmasiutin thanks! However, for some reason, SHASUM check is failing and I'm going on vacation. I message terraform-registry few days ago and I have no idea, what's wrong there... I'll try more debugging and hopefully find some issue.

@petoju
Copy link
Owner

petoju commented Aug 6, 2025

Ah, so this time, the sync has worked - now, 3.0.84 is released with your changes.

@maximmasiutin
Copy link
Contributor Author

Thank you very much! I run terraform init -upgrade to use the newest 3.0.84 and then column-level grants started to work properly - the issue is resolved, thank you for the prompt action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants